[BUG] resources IDs are not unique and collide with other formulas

[javierbertoli]

Your setup

Formula commit hash / release tag

Tested using commit 19617a0 (tag v1.2.2)

Versions reports (master & minion)

# salt --versions-report
Salt Version:
          Salt: 3002.5
 
Dependency Versions:
          cffi: Not Installed
      cherrypy: unknown
      dateutil: 2.7.3
     docker-py: Not Installed
         gitdb: 2.0.5
     gitpython: 2.1.11
        Jinja2: 2.10
       libgit2: 0.27.7
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 0.5.6
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     pycparser: 2.20
      pycrypto: 2.6.1
  pycryptodome: 3.6.1
        pygit2: 0.27.4
        Python: 3.7.7 (default, Apr  1 2020, 13:48:52)
  python-gnupg: Not Installed
        PyYAML: 3.13
         PyZMQ: 17.1.2
         smmap: 2.0.5
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.2
 
System Versions:
          dist: debian testing bullseye
        locale: utf-8
       machine: x86_64
       release: 5.10.0-1-amd64
        system: Linux
       version: Debian GNU/Linux testing bullseye

Pillar / config used

No config needed, just using the followin top.sls

base:
  mail:
    - mysql.client
    - postfix
    - postfix.config
    - postfix.mysql
    - postfix.pcre

---

Bug details

Describe the bug

There are conflicting resource IDs between the mysql.client and postfix.mysql state files.

Steps to reproduce the bug

~# salt 'mail' state.apply
ERROR: Minions returned with non-zero exit code
mail:
    Data failed to compile:
----------
    Detected conflicting IDs, SLS IDs need to be globally unique.
    The conflicting ID is 'mysql' and is found in SLS 'base:mysql.client' and SLS 'base:postfix.mysql'

Expected behaviour

ID's should not conflict.

Attempts to fix the bug

See PR #120

Additional context

[saltstack-formulas-travis]

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀