fix(resources): modify names to match template-formula's #120
Conversation
There was a problem hiding this comment.
Does this PR introduce a BREAKING CHANGE?
No, but will break dependencies to this formula resources's IDs being used in other formulas.
I think this would be considered a BREAKING CHANGE to be sure users would notice the change and adapt their own SLS if required.
Thanks.
|
@baby-gnu I agree, modified the message. I just was not sure if external dependencies on this formula (while the formula's functionality remained the same), was a reason enough to mark it as a BREAKING CHANGE. But I noticed we did the same in the template-formula so makes sense to mark it as such. 😋 |
|
@javierbertoli The tests aren't running because Please amend the commit to fix that, so that the CI continues to work. However, I've manually started all of the jobs and the good news is that they're passing:
I agree with the It would be worth glancing over that list to see if there is anything obvious that would need to be fixed. In terms of merging, we have a codeowner defined for this formula, so let's give @fzipi a chance to review this PR. Thanks for finding the issue and supplying a prompt fix! |
The new format match the format proposed in the template-formula BREAKING CHANGE: as all resources' IDs changed, other formulas depending on this formula's resources will need to be modified accordingly.
|
LGTM (other that fixing the lint problem). Do you think we should clarify somewhere the naming format used from now on? |
|
@javierbertoli Merged. Thanks for the reviews, @baby-gnu @fzipi.
@javierbertoli What do you think about this issue? Cover it in another PR? |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No, but will break dependencies to this formula resources's IDs being used in other formulas.
Related issues and/or pull requests
Should fix #119
Describe the changes you're proposing
Modified the resources IDs in the state files to follow the pattern proposed in the template-formula
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context