Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aartipandey01
Copy link

  1. Updated the base image in the second stage: I replaced the base image ibm-semeru-runtimes:open-11.0.18_10-jre with adoptopenjdk:11-jre-hotspot.

2.Removed the unnecessary environment variable export $(cat .env | xargs)

@chinmoy12c
Copy link
Member

  1. Updated the base image in the second stage: I replaced the base image ibm-semeru-runtimes:open-11.0.18_10-jre with adoptopenjdk:11-jre-hotspot.

2.Removed the unnecessary environment variable export $(cat .env | xargs)

Hey Aarti, why are these changes needed? What is the advantage of using another JVM?

@Aartipandey01
Copy link
Author

why are these changes needed? What is the advantage of using another JVM?

@chinmoy12c , The advantage of using "adoptopenjdk:11-jre-hotspot" is that it is a widely-used and community-supported distribution of OpenJDK, which provides an open-source implementation of the JDK and the JRE,

  1. Line "ENV export $(cat .env | xargs)" in the second stage, which reads environment variables from a file named ".env" and exports them, has been removed bcz eliminate unnecessary complexity and potential security risks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants