test-info.yml: Add method to share section
#121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'variant' is no longer relevant with sit-test-cases as it calculates the flapping list based on the access method used in each of the shares. So specify the method for each share section. 'variant' will be removed once sit-test-cases switches to look at 'method'. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
force-pushed
the
test-info-use-method
branch
from
1284c64 to
025c6e2
Compare
anoopcs9
changed the title
variant with methodmethod to share section
anoopcs9
added a commit
to anoopcs9/sit-test-cases
that referenced
this pull request
Aug 30, 2024
samba-in-kubernetes/sit-environment#121 adds 'method' to share section in test-info.yml. With 'variant' no longer relevant, prefer 'method' to determine the need for VFS specific flapping file. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
added a commit
to anoopcs9/sit-test-cases
that referenced
this pull request
Aug 30, 2024
samba-in-kubernetes/sit-environment#121 adds 'method' to share section in test-info.yml. With 'variant' no longer relevant, prefer 'method' to determine the need for VFS specific flapping file. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
added a commit
to anoopcs9/sit-test-cases
that referenced
this pull request
Aug 30, 2024
samba-in-kubernetes/sit-environment#121 adds 'method' to share section in test-info.yml. With 'variant' no longer relevant, prefer 'method' to determine the need for VFS specific flapping file. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
added a commit
to anoopcs9/sit-test-cases
that referenced
this pull request
Aug 30, 2024
samba-in-kubernetes/sit-environment#121 adds 'method' to share section in test-info.yml. With 'variant' no longer relevant, prefer 'method' to determine the need for VFS specific flapping file. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
added a commit
to anoopcs9/sit-test-cases
that referenced
this pull request
Aug 30, 2024
samba-in-kubernetes/sit-environment#121 adds 'method' to share section in test-info.yml. With 'variant' no longer relevant, prefer 'method' to determine the need for VFS specific flapping file. Signed-off-by: Anoop C S <[email protected]>
Shwetha-Acharya
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variantis no longer relevant with sit-test-cases as it calculates the flapping list based on the access method used in each of the shares. So specify the method for each share section.variantwill be removed once sit-test-cases switches to look atmethod.