Improved Web Store Management #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it also be possible to add an |
I think this already exists from this commit. |
|
yes, sweet! |
Co-authored-by: Sam Maddock <[email protected]>
samuelmaddock
requested changes
May 17, 2025
Comment on lines
+356
to
+358
| queueMicrotask(() => { | ||
| webStoreState.afterUninstall?.({ id }) | ||
| }) |
There was a problem hiding this comment.
Is the queueMicrotask needed?
Suggested change
| queueMicrotask(() => { | |
| webStoreState.afterUninstall?.({ id }) | |
| }) | |
| webStoreState.afterUninstall?.({ id }) |
| session: webStoreState.session, | ||
| extensionsPath: webStoreState.extensionsPath, | ||
| } | ||
| await webStoreState.customSetExtensionEnabled(id, details, enabled) |
There was a problem hiding this comment.
Rename to setExtensionEnabled and add documentation referencing chrome.management.setEnabled
| @@ -50,6 +50,23 @@ function getExtensionInstallStatus( | |||
| extensionId: ExtensionId, | |||
| manifest?: chrome.runtime.Manifest, | |||
| ) { | |||
| if (state.overrideExtensionInstallStatus) { | |||
There was a problem hiding this comment.
Rename to getExtensionInstallStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it possible for users to create a custom extensions management system (Install, Uninstall, Enable & Disable)
Changes
afterInstalloption toinstallChromeWebStore(), which allows the users to specifically track extensions installed via the webstore.afterUninstalloption toinstallChromeWebStore(), which allows the users to specifically track extensions uninstalled via the webstoreoverrideExtensionInstallStatusoption toinstallChromeWebStore(), which allows the users to override the extension state passed to the webstore. (eg: Disabled, Blacklisted, Corrupted, etc)Why?
These changes allowed me to implement a custom extension management system here, while maintaining the state with
electron-chrome-web-store.closes #116
✅ By sending this pull request, I agree to the Contributor License Agreement of this project.