Plan of study scraper #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: need to ignore empty json files (web pages with no plan of study)
KobeZ123
requested changes
Feb 24, 2025
src/urls/urls.ts
Outdated
| "https://nextcatalog.northeastern.edu/", | ||
| startYear === currentYear | ||
| ? "" | ||
| : `archive/${startYear}-${startYear + 1}/#planofstudytext`, |
There was a problem hiding this comment.
is this the same code as scrapeMajorLinks()? if so, we can abstract the two methods with something like a suffix parameter if only the suffix changes
scrapeMajorLinks('') and scrapeMajorLinks('#plan-of-study')
There was a problem hiding this comment.
just note don't want these files in the final
src/runtime/index.ts
Outdated
| //PhaseLabel.ScrapeMajorLinks, | ||
| //scrapeMajorPlanLinks(year, currentYear), | ||
| //) | ||
| //.then(addPhase(spin, PhaseLabel.Classify, classify)) |
There was a problem hiding this comment.
are the classify and tokenize phases removed? it would be useful to log the tokens scraped before parsing
i think there might be an issue where it scrapes everything twice
todo: scrape note on plan of study as well (e.g. https://catalog.northeastern.edu/archive/2022-2023/undergraduate/science/physics/applied-physics-bs/#planofstudytext)
denniwang
force-pushed
the
plan-of-study-scraper
branch
from
bed9498 to
04b755c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrapes plan of studies. Still need to implement automated scraping for list of urls. Given a plan of study HTML table it is able to scrape all the properly formatted classes.