Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyStudiesPage responsiveness UI update #149

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

leeyandrea
Copy link

  • fixed the responsiveness by changing the structure of thing:
  • Instead of a MyStudiesItem and each study being an individual component, I turned it into a MyStudiesTable using proper HTML , , , , and
    elements.
  • Made a dedicated RecentStudiesSection that contains RecentStudiesItem to handle that part of the screen
  • Changed RecentStudiesItem from using divs to using Element Plus Card component
  • significantly cleaned up the acutal MyStudiesPage, only containing the recentStudiesSection and the MyStudiesTable
  • changed min widths and flex box issues for responsiveness and added padding
  • Removed excessive nested divs
  • Used more straightforward flex layouts with proper spacing
  • Acknowledge problems:

    • still have some uncommented code for reference, a lil messy
    • still have the MyStudiesItem.vue for reference but we probably don't need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants