Skip to content

Conversation

@jtgrasb
Copy link
Collaborator

@jtgrasb jtgrasb commented Oct 31, 2025

Description

This PR removes the numpy restrictions (see #391) which were a result of autograd being outdated. Since we switched to jax, this update is relatively straightforward but did require switching np.NaN to np.nan in the AH example.

This PR also address coverage issues that we've been having. By reverting back to coverage instead of pytest-cov, the coverage data will actually be uploaded to coveralls (instead of displaying as 0%). I also added

[tool.coverage.run]
source = [
    "wecopttool",
]

to pyproject.toml, which specifies only coverage for files in the source directory should be recorded. This fixes an error with the ubuntu tests trying to find some _netcdf4.pyx file.

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: (specify)

Checklist for PR

@coveralls
Copy link

coveralls commented Oct 31, 2025

Pull Request Test Coverage Report for Build 19303447727

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+88.1%) to 88.079%

Totals Coverage Status
Change from base Build 18696515447: 88.1%
Covered Lines: 1256
Relevant Lines: 1426

💛 - Coveralls

@jtgrasb jtgrasb mentioned this pull request Nov 12, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants