Skip to content

CLI options for controlling Cython extension compliation #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reuseable-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- name: Install package (No Cython)
if: ${{ inputs.use-cython != 'true' }}
run: |
python -m pip install -e .[testing_no_cython]
PYGSTI_CYTHON_SKIP=1 python -m pip install -e .[testing_no_cython]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix #559

- name: Lint with flake8 (Linux only)
if: ${{ inputs.os == 'ubuntu-latest'}}
run: |
Expand Down
1 change: 0 additions & 1 deletion MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
include README.md CONTRIBUTING.md LICENSE
include pyproject.toml
include install_locally.py
include requirements.txt
include optional-requirements.txt
include jupyter_notebooks/START_HERE.ipynb
Expand Down
3 changes: 2 additions & 1 deletion pygsti/layouts/prefixtable.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

import collections as _collections
import networkx as _nx
import matplotlib.pyplot as plt
from math import ceil
from pygsti.baseobjs import Label as _Label
from pygsti.circuits.circuit import SeparatePOVMCircuit as _SeparatePOVMCircuit
Expand Down Expand Up @@ -1208,6 +1207,8 @@ def _draw_graph(G, node_label_key='label', edge_label_key='promotion_cost', figu
An optional size specifier passed into the matplotlib figure
constructor to set the plot size.
"""
import matplotlib.pyplot as plt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved import that broke minimal install. Matplotlib is an optional dependency currently.


plt.figure(figsize=figure_size)
pos = _nx.nx_agraph.graphviz_layout(G, prog="dot", args="-Granksep=5 -Gnodesep=10")
labels = _nx.get_node_attributes(G, node_label_key)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ keywords=[
classifiers=[
"Development Status :: 4 - Beta",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Topic :: Scientific/Engineering :: Physics",
"Operating System :: Microsoft :: Windows",
"Operating System :: MacOS :: MacOS X",
"Operating System :: Unix"
]
license = "Apache-2.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous classifier was deprecated in favor of this.


[project.optional-dependencies]
diamond_norm = [
Expand Down
12 changes: 0 additions & 12 deletions setup.cfg

This file was deleted.

Loading