Use find_package for Finding Hwloc in CMake
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figure find_package.
… be overriden using hwloc_ROOT downstream.
insertinterestingnamehere
force-pushed
the
cmake
branch
from
c995883 to
fb4ed14
Compare
insertinterestingnamehere
merged commit 2893988
into
sandialabs:main
349 of 359 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a need downstream for being able to configure hwloc via the standard
_ROOTmechanism as opposed to just supplying a hint since the hint can get unintentionally overridden byCMAKE_MODULE_PATH. This required setting up a find module for hwloc and then using find_package to find it instead, as is done here.