Merge pull request #4610 from sanger/Y24-307

add new plate purpose for pre-ready made libraries for multiplexing
sanger · Jan 31, 2025 · 6d08266 · 6d08266
2 parents 6c137ad + f466742
commit 6d08266
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/app/models/submission/flexible_request_graph.rb b/app/models/submission/flexible_request_graph.rb
@@ -110,6 +110,8 @@ def build! # rubocop:todo Metrics/AbcSize
             .order
             .create_request_of_type!(request_type, asset: source_asset, target_asset: target_asset)
             .tap do |request|
+              # Removed from linear_request_graph module as it caused unnecessary links in pipelines where
+              # a limber_multiplexing request is the first step.
               if source_asset&.labware.present? && target_asset&.labware.present?
                 AssetLink.create_edge(source_asset.labware, target_asset.labware)
               end

diff --git a/app/models/submission/linear_request_graph.rb b/app/models/submission/linear_request_graph.rb
@@ -88,14 +88,6 @@ def create_request_chain!(request_type_and_multiplier_pairs, source_data_set, mu
         target_asset = target_assets[index]
 
         create_request_of_type!(request_type, asset: source_asset, target_asset: target_asset).tap do |request|
-          # TODO: AssetLink is supposed to disappear at some point in the future because it makes no real sense
-          # given that the request graph describes this relationship.
-          # JG: Its removal only really makes sense if we can walk the request graph in a timely manner.
-          # We use save not save! as AssetLink throws validation errors when the link already exists
-          if source_asset&.labware.present? && target_asset&.labware.present?
-            AssetLink.create_edge(source_asset.labware, target_asset.labware)
-          end
-
           request.qc_metrics = qc_metrics.compact.uniq
           request.update_responsibilities!
 

diff --git a/config/default_records/plate_purposes/005_limber_purposes.yml b/config/default_records/plate_purposes/005_limber_purposes.yml
@@ -77,3 +77,8 @@ LTN Lib PCR XP:
 RVI Lib PCR XP:
   type: PlatePurpose
   stock_plate: false
+
+# A plate provided as ready-made libraries.
+# These used to be imported as Stock Plates and then 'fake cherrypicked' onto 'LB Lib PCR XP', which were allowed down the multiplexing pipelines.
+# Now, they can be imported and submitted as this more accurate plate purpose.
+Library Stock Plate: *limber_input_96