Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add syslog as separate gem #4662

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

StephenHulme
Copy link
Contributor

Follows on from #4647 with syslog.

Removes warning:

/Users/[user]/.rbenv/versions/3.3.6/lib/ruby/3.3.0/syslog/logger.rb:2: warning: /Users/[user]/.rbenv/versions/3.3.6/lib/ruby/3.3.0/arm64-darwin24/syslog.bundle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add syslog to your Gemfile or gemspec to silence this warning.

Changes proposed in this pull request

  • Add syslog as separate dependency in Gemfile

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (29a2e2c) to head (b80add8).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4662      +/-   ##
===========================================
- Coverage    89.43%   89.34%   -0.09%     
===========================================
  Files         1406     1406              
  Lines        30296    30296              
===========================================
- Hits         27095    27069      -26     
- Misses        3201     3227      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephenHulme StephenHulme merged commit 088dcf7 into develop Feb 4, 2025
22 of 23 checks passed
@StephenHulme StephenHulme deleted the sh51/add-syslog-to-gemfile branch February 4, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants