-
Notifications
You must be signed in to change notification settings - Fork 497
feat(sanity): enable editing canvas documents #11421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
🧪 E2E Preview environment🔑 Environment Variables for Local TestingThis is the preview URL for the E2E tests: https://e2e-studio-4ir7pu21j.sanity.dev To run the E2E tests locally, you can use the following environment variables, then run 💬 Remember to build the project first with |
📊 Playwright Test ReportThis report contains test results, including videos of failing tests. |
⚡️ Editor Performance ReportDeploying studio and running performance tests… |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…b.com:sanity-io/sanity into feat_crx_1806_enable_editing_canvas_documents
|
Hey @stipsan, sorry for the switch back to draft mode when I opened this. This should be ready for review now |
pedrobonamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you!
snorrees
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, have not tested yet, will be back, might not make it today.
Description
We're preparing Canvas -> Studio syncing that will allow for documents to be edited in Studio.
To enable this in a feature branch and have it working with the current setup we've added
isStudioDocumentEditableto thesanity.canvas.linkWhen
isStudioDocumentEditableis true, we'll enable editing in Studio. If false or not defined, the current locked behavior stays.New copy:

The Canvas banner has a new copy—only one style, we're not differentiating the type of document for editable ones.
Popover - when the info icon in the banner is clicked

What to review
If you're not on Canvas team, mainly focus on the code review and regression testing for linking because a canvas + BE branch is required.
For reviewers with access to Canvas
Testing
Notes for release
No public announcement necessary