Skip to content

fix: include feature breakdown in main branch bench summary#21

Merged
RostiMelk merged 1 commit intomainfrom
fix/bench-summary-features
Feb 7, 2026
Merged

fix: include feature breakdown in main branch bench summary#21
RostiMelk merged 1 commit intomainfrom
fix/bench-summary-features

Conversation

@RostiMelk
Copy link
Member

Feature cost breakdown was only shown in PR summaries. Now it's appended for main branch runs too, and deduplicated out of the if/elif branches.

@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-logo-soup Ready Ready Preview, Comment Feb 7, 2026 3:49pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Benchmark Comparison: main vs fix/bench-summary-features

Threshold: 5%+ change, >100us absolute delta, and statistically significant (p<0.05).

Benchmark main fix/bench-summary-features Change p-value Verdict
content detection (1 logo) 33.43 us 31.29 us -6.4% 0.072 unchanged
render pass (20 logos) 1.12 us 1.11 us -0.9% 0.789 unchanged
mount 20 logos (no detection) 3.28 us 3.03 us -7.6% 0.317 unchanged
mount 20 logos (defaults) 793.21 us 800.08 us +0.9% 0.395 unchanged

No regressions detected.

Feature cost breakdown

How expensive are individual features? Measured on this run's HEAD commit.

Feature On Off Cost Sig
densityAware: true vs false 30.89 us 31.38 us ~same 0.534
alignBy: visual-center-y vs bounds 878 ns 54 ns 16× slower <0.001 ***
cropToContent: true vs false 2.04 ms 41 ns 2.04 ms <0.001 ***
layout update: full mount vs cached 792.44 us 1.75 us 452× slower <0.001 ***

Full benchmark output in the CI job logs.

@RostiMelk RostiMelk merged commit cc80a83 into main Feb 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant