[FLINK-40664][tests] Isolate MDC logging test clusters - #1
sankalpsthakur wants to merge 2 commits into
Conversation
…gITCase Ignored log patterns now skip matching events even when they carry a different MDC job ID. MiniCluster tests can observe TaskExecutor slot cleanup for another job; that used to fail as "wrong value". Generated-by: Cursor Grok 4.6 Co-authored-by: Sankalp Thakur <sankalpsthakur@users.noreply.github.com>
sankalpsthakur
left a comment
sankalpsthakur
left a comment
There was a problem hiding this comment.
AI-assisted review of 244995b: this changes the shared JobIDLoggingUtil contract, not just one ignored message. Matching events are now discarded before both the MDC check and expected-pattern accounting.
The unignored wrong-value negative test is useful. Add coverage for an unignored missing key and for an event matching both expected and ignored patterns, making the intended precedence explicit. Check other helper callers for overlap.
The reported three unit tests establish the helper behavior only. Run the affected JobIDLoggingITCase/MiniCluster case repeatedly, retaining a before-fix failure or deterministic reproduction. Do not present passing helper tests as evidence that the original nightly flake is resolved. I have not run the Flink suites in this review.
…ion precedence Generated-by: ChatGPT GPT-6 Astra Pro
sankalpsthakur
changed the title
1 participant
Tracking fork for apache/flink#29235, using the same source branch. Review upstream; do not merge this fork PR.
At
9d2c0a0b,EnrichedMdcLoggingITCasehas its own MiniCluster. The originalJobIDLoggingUtilassertion order is preserved; no production helper changes remain. Tests cover all four wrong-job cleanup messages and an event matching both expected and ignored patterns.Upstream Azure build 79245 is reported successful for this exact head. This is existing CI evidence, not a new local run or maintainer approval. The upstream title/body and response to the review still need updating to describe this implementation.
JIRA: FLINK-40664.
Generated-by: Cursor Grok 4.6.