Fix JSON structure for multi-target scans and swallowed error messages#65
Merged
Merged
Conversation
Bug 1: information_disclosure and caching were stored as top-level keys in json_headers rather than nested under the URL key alongside present and missing. When scanning multiple targets, each target's data overwrote the previous one. Fixed by writing into json_results instead. Bug 2: Two print() calls in check_target (UnknownProtocol and "Couldn't read a response from server.") were silently swallowed when -j was active, because -j redirects sys.stdout to devnull. Fixed by using sys.stderr.write() so errors are always visible. Tests updated to reflect the corrected nested JSON structure and to assert error messages reach stderr. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: information_disclosure and caching were stored as top-level keys in json_headers rather than nested under the URL key alongside present and missing. When scanning multiple targets, each target's data overwrote the previous one. Fixed by writing into json_results instead.
Bug 2: Two print() calls in check_target (UnknownProtocol and "Couldn't read a response from server.") were silently swallowed when -j was active, because -j redirects sys.stdout to devnull. Fixed by using sys.stderr.write() so errors are always visible.
Tests updated to reflect the corrected nested JSON structure and to assert error messages reach stderr.