-
Notifications
You must be signed in to change notification settings - Fork 20
release: merge dev to stage for 1.3.0 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
all: Update image fragments to align with sap_infrastructure PR#118
sap_s4hana_sandbox_syscopy: Update readme entry for S4HANA
all: Update playbooks for ansible-core 2.19
collection: Update linting and sanity workflows to align with project
collection: Bump requirements versions to support 2.19
all: Add sles16 images for AWS, AZ, GCP
collection: Update Contributors list
ja9fuchs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
sean-freeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just minor catches. It is best to ask Edmund to speak with Walter or Graham and do a sanity re-test of the IBM Power targets - particularly given IBM Power VS has rapidly changed in the past 12 months and now (finally) has SG capabilities too.
ibmcloud_powervs: Update variables for better clarity
sean-freeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All 3 minor comments resolved. LGTM 👍
Minor Changes