sap_vm_provision/kubevirt_vm: Make usage of hugepages configurable

[newkit]

This addresses the enhancement described here:

When creating a VM, currently the usage of hugepages is mandatory, see here.

Let's add a flag in to the VM definition to switch off the usage of hugepages:

sap_vm_provision_kubevirt_vm_host_specifications_dictionary:
  example_host_specification_plan:
    host1: # Hostname, must be 13 characters or less
      # SMT-2 (i.e. 2 CPU Threads per CPU Core) is default for Intel CPU Hyper-Threading, optionally can be altered to SMT-1
      kubevirt_vm_cpu_smt: 2
      kubevirt_vm_cpu_cores: 2
      kubevirt_vm_memory_gib: 24
      hugepages: false # false | 1Gi | <hugepage size> 

When omitted / by default hugepages should be on to be backwards compatible.

[marcelmamula]

Review done with few changes to be made

[marcelmamula]

Last name change before LGTM

[newkit]

Hi @marcelmamula, i've renamed the var's as suggested, please take a look.

[marcelmamula]

@newkit Rename makes change, but comments are not aligned with it now, because key name is hypervisor, but comments says it is for VM inside of it.

I would see it like, this: Clear and does not confuse with having 2 keys with same name.

      kubevirt_vm_cpu_cores: 2
      kubevirt_vm_memory_gib: 24
      # Defines size of huge pages for kubervirt hypervisor (e.g. '2Gi')
      # This can be disabled by setting value at 'false'. The default value is '1Gi'.
      kubevirt_vm_memory_hypervisor_hugepages: 1Gi

@sean-freeman It would better to continue in one thread instead of jumping between PR and Issue.

[newkit]

Done @marcelmamula

[marcelmamula]

@newkit Add review comments and also adding @sean-freeman into reviewers as he is involved.

[marcelmamula]

@newkit Any progress on fixing this task I reported last week? Its message needs improving.

    - name: Stop execution of playbook here if an error has occurred
      ansible.builtin.fail:
        msg: "Stop entire playbook since something when wrong."

[newkit]

@newkit Any progress on fixing this task I reported last week? Its message needs improving.

@marcelmamula I've updated the error message.

[marcelmamula]

LGTM