default for package dictionaries to simplify vars

roles/sap_ha_pacemaker_cluster/vars/platform_cloud_aws_ec2_vs.yml

@@ -3,9 +3,11 @@
 #
 # TODO: make sure to first respect 'ha_cluster' native variables
 
-sap_ha_pacemaker_cluster_fence_agent_packages: "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_aws }}"
+sap_ha_pacemaker_cluster_fence_agent_packages:
+  "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_aws | default([]) }}"
 
-__sap_ha_pacemaker_cluster_platform_extra_packages: "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_aws }}"
+__sap_ha_pacemaker_cluster_platform_extra_packages:
+  "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_aws | default([]) }}"
 
 __sap_ha_pacemaker_cluster_repos:
   - id: "rhel-{{ ansible_distribution_major_version }}-for-{{ ansible_architecture }}-highavailability-e4s-rhui-rpms"

roles/sap_ha_pacemaker_cluster/vars/platform_cloud_gcp_ce_vm.yml

@@ -3,9 +3,11 @@
 #
 # TODO: make sure to first respect 'ha_cluster' native variables
 
-sap_ha_pacemaker_cluster_fence_agent_packages: "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_gcp }}"
+sap_ha_pacemaker_cluster_fence_agent_packages:
+  "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_gcp | default([]) }}"
 
-__sap_ha_pacemaker_cluster_platform_extra_packages: "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_gcp }}"
+__sap_ha_pacemaker_cluster_platform_extra_packages:
+  "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_gcp | default([]) }}"
 
 __sap_ha_pacemaker_cluster_repos:
   - id: "rhel-{{ ansible_distribution_major_version }}-for-{{ ansible_architecture }}-highavailability-e4s-rhui-rpms"

roles/sap_ha_pacemaker_cluster/vars/platform_cloud_ibmcloud_powervs.yml

@@ -3,9 +3,11 @@
 #
 # TODO: make sure to first respect 'ha_cluster' native variables
 
-sap_ha_pacemaker_cluster_fence_agent_packages: "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_ibmcloud_powervs }}"
+sap_ha_pacemaker_cluster_fence_agent_packages:
+  "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_ibmcloud_powervs | default([]) }}"
 
-__sap_ha_pacemaker_cluster_platform_extra_packages: "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_ibmcloud_powervs }}"
+__sap_ha_pacemaker_cluster_platform_extra_packages:
+  "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_ibmcloud_powervs | default([]) }}"
 
 __sap_ha_pacemaker_cluster_repos:
   - id: "rhel-{{ ansible_distribution_major_version }}-for-{{ ansible_architecture }}-highavailability-e4s-rpms"

roles/sap_ha_pacemaker_cluster/vars/platform_cloud_ibmcloud_vs.yml

@@ -3,9 +3,11 @@
 #
 # TODO: make sure to first respect 'ha_cluster' native variables
 
-sap_ha_pacemaker_cluster_fence_agent_packages: "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_ibmcloud_vs }}"
+sap_ha_pacemaker_cluster_fence_agent_packages:
+  "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_ibmcloud_vs | default([]) }}"
 
-__sap_ha_pacemaker_cluster_platform_extra_packages: "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_ibmcloud_vs }}"
+__sap_ha_pacemaker_cluster_platform_extra_packages:
+  "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_ibmcloud_vs | default([]) }}"
 
 __sap_ha_pacemaker_cluster_repos:
   - id: "rhel-{{ ansible_distribution_major_version }}-for-{{ ansible_architecture }}-highavailability-e4s-rpms"

roles/sap_ha_pacemaker_cluster/vars/platform_cloud_msazure_vm.yml

@@ -6,9 +6,11 @@
 # The packages of the following lists will be installed by the 'ha_cluster' Linux System Role.
 # Any packages that are pre-requisites for variable construction must be installed before, e.g.
 # in the preconfigure-* tasks.
-sap_ha_pacemaker_cluster_fence_agent_packages: "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_msazure_vm }}"
+sap_ha_pacemaker_cluster_fence_agent_packages:
+  "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.cloud_msazure_vm | default([]) }}"
 
-__sap_ha_pacemaker_cluster_platform_extra_packages: "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_msazure_vm }}"
+__sap_ha_pacemaker_cluster_platform_extra_packages:
+  "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.cloud_msazure_vm | default([]) }}"
 
 __sap_ha_pacemaker_cluster_repos:
   - id: "rhel-{{ ansible_distribution_major_version }}-for-{{ ansible_architecture }}-highavailability-e4s-rhui-rpms"

roles/sap_ha_pacemaker_cluster/vars/platform_hyp_ibmpower_vm.yml

@@ -3,9 +3,11 @@
 # TODO: rename this file to match the actual "chassis_asset_tag" output
 # TODO: make sure to first respect 'ha_cluster' native variables
 
-sap_ha_pacemaker_cluster_fence_agent_packages: "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.hyp_ibmpower_vm }}"
+sap_ha_pacemaker_cluster_fence_agent_packages:
+  "{{ sap_ha_pacemaker_cluster_fence_agent_packages_dict.hyp_ibmpower_vm | default([]) }}"
 
-__sap_ha_pacemaker_cluster_platform_extra_packages: "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.hyp_ibmpower_vm }}"
+__sap_ha_pacemaker_cluster_platform_extra_packages:
+  "{{ __sap_ha_pacemaker_cluster_platform_extra_packages_dict.hyp_ibmpower_vm | default([]) }}"
 
 __sap_ha_pacemaker_cluster_repos:
   - id: "rhel-{{ ansible_distribution_major_version }}-for-{{ ansible_architecture }}-highavailability-e4s-rpms"

roles/sap_ha_pacemaker_cluster/vars/redhat.yml

@@ -46,11 +46,8 @@ __sap_ha_pacemaker_cluster_platform_extra_packages_dict:
     - awscli
   cloud_gcp:
     - resource-agents-gcp
-  cloud_ibmcloud_powervs: []
-  cloud_ibmcloud_vs: []
   cloud_msazure_vm:
     - socat
-  hyp_ibmpower_vm: []
 
 # Dictionary with additional cluster packages for specific scenarios
 __sap_ha_pacemaker_cluster_sap_extra_packages_dict:

roles/sap_ha_pacemaker_cluster/vars/suse.yml

@@ -21,24 +21,14 @@ sap_ha_pacemaker_cluster_fence_agent_minimal_packages:
 
 # Dictionary with fence packages for each platform
 # SUSE does not use platform specific fence agents, just fence-agents
-sap_ha_pacemaker_cluster_fence_agent_packages_dict:
-  cloud_aws: []
-  cloud_gcp: []
-  cloud_ibmcloud_powervs: []
-  cloud_ibmcloud_vs: []
-  cloud_msazure_vm: []
-  hyp_ibmpower_vm: []
+# sap_ha_pacemaker_cluster_fence_agent_packages_dict:
 
 # Dictionary with extra platform specific packages
 __sap_ha_pacemaker_cluster_platform_extra_packages_dict:
   cloud_aws:
     - awscli
-  cloud_gcp: []
-  cloud_ibmcloud_powervs: []
-  cloud_ibmcloud_vs: []
   cloud_msazure_vm:
     - socat
-  hyp_ibmpower_vm: []
 
 # Dictionary with additional cluster packages for specific scenarios
 __sap_ha_pacemaker_cluster_sap_extra_packages_dict: