Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_vm_preconfigure: implement ansible-lint changes #554

Merged
merged 4 commits into from
Jan 15, 2024
Merged

sap_vm_preconfigure: implement ansible-lint changes #554

merged 4 commits into from
Jan 15, 2024

Conversation

newkit
Copy link
Contributor

@newkit newkit commented Dec 19, 2023

Implemented the ansible-lint suggestions.

There are three open issues in code you have added @sean-freeman, could you please take a look?

yaml[indentation]: Wrong indentation: expected 4 but found 2
tasks/detect_platform/main.yml:82

yaml[indentation]: Wrong indentation: expected 4 but found 2
tasks/detect_platform/main.yml:115

yaml[empty-lines]: Too many blank lines (1 > 0)
tasks/detect_platform/main.yml:131

@berndfinger berndfinger changed the title sap_vm_preconfigure: implemented ansible-lint changes sap_vm_preconfigure: implement ansible-lint changes Dec 20, 2023
sean-freeman
sean-freeman requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After typo fix, lgtm 👍

@berndfinger
Copy link
Member

@newkit Please remove the changes for file roles/sap_vm_preconfigure/.ansible-lint from this PR in a new commit. The file has already been updated in the meantime with additional changes in the already merged PR #594.

berndfinger
berndfinger reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

berndfinger
berndfinger approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sean-freeman
sean-freeman approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@berndfinger berndfinger merged commit 2eb9276 into sap-linuxlab:dev Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-freeman sean-freeman sean-freeman approved these changes

@berndfinger berndfinger berndfinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newkit @berndfinger @sean-freeman