-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge dev to main for release 1.5.1 #933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate Automation: number outdated packages in requirements-workflow.txt
Merge pull request #908 from sap-linuxlab/dev
…g and setting Fixes issue #907. Signed-off-by: Bernd Finger <[email protected]>
…ent package detection
…ame as per comment in defaults/main.yml
…one when angi is used
…ble while using the OS default hook list
sap_*_preconfigure, sap_ha_pacemaker_cluster: Vars loading reworked, Linting fixes for yes/no
sap_ha_pacemaker_cluster: ANGI on RHEL and small improvements
Fixes #921. The SAP Solution Manager JAVA Export file (e.g. 51054655_4.zip) contains files with the search pattern for 'sap_export_nwas_java' before files with the search pattern for 'sap_export_solman_java'. So we fall through (= do no longer exit) for the search pattern of the SAP Netweaver Java files (e.g. 51055106.zip). This will work as long as such files do not have content which are matched by any other search pattern. Tested with: 51050829_3 (NW 7.5 Installation Export) 51054655_1 (SAP Solution Manager 7.2 SR2 Installation Export I) 51054655_2 (SAP Solution Manager 7.2 SR2 Installation Export II) 51054655_4 (SAP Solution Manager 7.2 SR2 - Java) 51055106 (SAP Netweaver 7.5 SP22 Java) $ sapfile *.zip 51050829_3.zip: sap_export_nwas_abap 51054655_1.zip: sap_export_solman_abap 51054655_2.zip: sap_export_solman_abap 51054655_4.zip: sap_export_solman_java 51055106.zip: sap_export_nwas_java Signed-off-by: Bernd Finger <[email protected]>
…port-detection sap_install_media_detect: Fix wrong sap_export_solman_java detection
PR conflict
Fixes issue #915. Signed-off-by: Bernd Finger <[email protected]>
Fixes issue #917. Signed-off-by: Bernd Finger <[email protected]>
…xtraMileTool sap_swpm: Use 'false' instead of 'False' in inifile.params
…ate_inifile sap_swpm: Add tag to sap_swpm_tmpdir task
Solves issue #909. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
... to the task running the localectl set-locale command Signed-off-by: Bernd Finger <[email protected]>
sap_swpm, sap_general_preconfigure: feat: add variables for sap_install collection name for calling roles
…itionally sap_swpm: Use master password only when necessary
Also slightly modify the variable description. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
sap_ha_pacemaker_cluster/SUSE: Rework SAPHanaSR-angi pre-steps and add SLES 16 vars
sap_swpm, sap_general_preconfigure: Fix some leftovers from #925
Signed-off-by: Bernd Finger <[email protected]>
sap_general_preconfigure - Checking for english locales, issue 907
…ride - the internal var must be used for the decision after auto-discovery, because otherwise it can be overridden by the user (issue: command-line extra-vars take precedence over set_fact) - the pre-steps were moved to the end of the including file in order to override the internal var after its default was set
sap_ha_pacemaker_cluster: enable Simple Mount on RHEL
Signed-off-by: Bernd Finger <[email protected]>
collection: prepare for v1.5.1
marcelmamula
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ja9fuchs
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Recent tests with the dev
code all went fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.