Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_general_preconfigure: No longer install locale packages in RHEL 7 #937

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

berndfinger
Copy link
Member

I am not aware of any issues related to missing English locales on RHEL 7, so we can safely assume that a RHEL 7 system will have all necessary English locale packages installed as part of installing the mandatory software environment group.

I am not aware of any issues related to missing English locales on RHEL
7, so we can safely assume that a RHEL 7 system will have all necessary
English locale packages installed as part of installing the mandatory
software environment group.

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger berndfinger requested a review from rhmk January 23, 2025 15:25
@rhmk
Copy link
Member

rhmk commented Jan 23, 2025

Well, nonetheless the role will complain, if the packages would be missing in a particular customer environment. Because of that I can approve the #PR.

Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger berndfinger merged commit c94c55e into sap-linuxlab:dev Jan 23, 2025
3 of 4 checks passed
@berndfinger berndfinger deleted the issue-936-rhel7-locale-en branch January 23, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants