Skip to content

sap_netweaver_preconfigure: fix argument_specs validation error #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion roles/sap_netweaver_preconfigure/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@ In assertion mode, the role will abort when encountering any assertion error.<br
If this parameter is set to `false`, the role will *not* abort when encountering an assertion error.<br>
This is useful if the role is used for reporting a system's SAP notes compliance.<br>

### sap_netweaver_preconfigure_packages
- _Type:_ `list` with elements of type `str`
- _Default:_ (set by platform/environment specific variables)

The list of packages to be installed for SAP NETWEAVER.<br>
The default for this variable is set in the vars file which corresponds to the detected OS version.<br>

### sap_netweaver_preconfigure_min_swap_space_mb
- _Type:_ `str`
- _Default:_ `20480`
Expand Down Expand Up @@ -156,4 +163,4 @@ Set this parameter to `true` when using Adobe Document Services, to ensure all r

(SUSE specific) Specifies the saptune solution to apply.<br>
Available values: `NETWEAVER`, `NETWEAVER+HANA`, `S4HANA-APP+DB`, `S4HANA-APPSERVER`, `S4HANA-DBSERVER`
<!-- END Role Variables -->
<!-- END Role Variables -->
18 changes: 9 additions & 9 deletions roles/sap_netweaver_preconfigure/meta/argument_specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ argument_specs:
short_description: Variables for SAP NetWeaver preconfiguration
options:

sap_netweaver_preconfigure_packages:
default: "{{ __sap_netweaver_preconfigure_packages }}"
description:
- The list of packages to be installed for SAP NETWEAVER.
- The default for this variable is set in the vars file which corresponds to the detected OS version.
required: false
type: list
elements: str

sap_netweaver_preconfigure_config_all:
default: true
description:
Expand Down Expand Up @@ -57,6 +48,15 @@ argument_specs:
required: false
type: bool

sap_netweaver_preconfigure_packages:
default: "{{ __sap_netweaver_preconfigure_packages }}"
description:
- The list of packages to be installed for SAP NETWEAVER.
- The default for this variable is set in the vars file which corresponds to the detected OS version.
required: false
type: list
elements: str

sap_netweaver_preconfigure_min_swap_space_mb:
default: '20480'
description:
Expand Down
3 changes: 3 additions & 0 deletions roles/sap_netweaver_preconfigure/vars/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
# define variables here that will not change
# Those are valid for all OS
#

# dummy entry for passing the arg spec validation:
__sap_netweaver_preconfigure_packages: []
Loading