Preserve symlink directory last modified times#51
Merged
Conversation
stanhu
force-pushed
the
sh-preserve-symlink-directory-mtime
branch
from
3bdcc4f to
955ba1f
Compare
saracen
force-pushed
the
sh-preserve-symlink-directory-mtime
branch
from
955ba1f to
1d8d4ba
Compare
Previously if a ZIP file contained symlinks, the symlink last modified times would be preserved, but the directories containing the symlink would have their last modified times updated because: 1. The directory is created first (if it doesn't exist). 2. The symlink is then created inside that directory. 3. Creating the symlink modifies the directory's mtime to the current time. 4. The directory timestamp restoration happens before or is overwritten by the symlink creation. Fix this by extracting all the symlinks before doing a final pass to update the modification times of all directories. Relates to saracen#40
stanhu
force-pushed
the
sh-preserve-symlink-directory-mtime
branch
from
1d8d4ba to
6c80acc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if a ZIP file contained symlinks, the symlink last modified times would be preserved, but the directories containing the symlink would have their last modified times updated because:
Fix this by extracting all the symlinks before doing a final pass to update the modification times of all directories.
Relates to #40