Auth routes#7
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds full ChangesUser Authentication with JWT and Password Hashing
Sequence Diagram(s)sequenceDiagram
participant Client
participant AuthRoutes as server.app.auth.routes
participant DB as users_db
participant Argon2 as PasswordHasher
participant JWT as JWTManager
Client->>AuthRoutes: POST /login (username,password)
AuthRoutes->>DB: SELECT user BY username
DB-->>AuthRoutes: user row or empty
AuthRoutes->>Argon2: verify(password, stored_hash) or verify(_DUMMY_HASH)
Argon2-->>AuthRoutes: verification result
AuthRoutes->>DB: UPDATE argon2id_server_hash/salt (if rehash needed)
AuthRoutes->>JWT: create_access_token(identity=user_id)
AuthRoutes-->>Client: 200 {access_token, user_fields}
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
server/app/auth/routes.py (1)
108-111: ⚡ Quick winNarrow exception handling in dummy-verify path to specific Argon2 exceptions.
Catching broad
Exceptioncan hide real failures. The dummy-verify code should only catch expected Argon2 verification exceptions:-from argon2.exceptions import VerifyMismatchError +from argon2.exceptions import VerifyMismatchError, VerificationError @@ - try: - ph.verify(_DUMMY_HASH, data['password']) - except Exception: - pass + try: + ph.verify(_DUMMY_HASH, data['password']) + except (VerifyMismatchError, VerificationError): + passThis catches password mismatches and other verification failures while allowing unexpected errors to propagate.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@server/app/auth/routes.py` around lines 108 - 111, The dummy verification currently swallows all exceptions in the ph.verify(_DUMMY_HASH, data['password']) call; narrow this by importing the specific Argon2 exceptions (e.g., VerifyMismatchError, VerificationError, InvalidHash from argon2.exceptions) and replace the broad "except Exception" with a targeted "except (VerifyMismatchError, VerificationError, InvalidHash):" so only expected verification failures are ignored and other unexpected errors still propagate.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@requirements.txt`:
- Around line 1-7: The requirements.txt lists unpinned packages (flask,
flask-jwt-extended, argon2-cffi, mysql-connector-python, web3, python-dotenv,
gunicorn) which makes builds unreproducible and exposes you to transitive vuln
regressions; replace this by generating and committing a fully pinned lock file
(e.g., requirements.lock from pip freeze or pip-tools) and update CI to validate
it, then update the repo to (1) add the lockfile (requirements.lock) with exact
versions for all direct and transitive deps, (2) modify or keep requirements.txt
to reference only top-level packages if needed, and (3) add a CI step using
pip-audit (or equivalent) to fail the build on vulnerable packages (with special
attention to flask-jwt-extended/PyJWT versions), ensuring future installs use
the lockfile to reproduce builds.
In `@server/app/auth/routes.py`:
- Around line 34-36: The current required-field check uses truthiness so
non-string values slip through; update the validation that builds missing to
require each field in REQUIRED_FIELDS be an instance of str and non-empty after
.strip() (e.g., replace the list comprehension that uses data.get(f) with an
isinstance(data.get(f), str) and data.get(f).strip() check) and return the same
400 JSON error if any fail; apply the identical type+non-empty validation logic
for the second occurrence referenced (lines 85-87) so auth inputs are validated
as strings at the boundary.
---
Nitpick comments:
In `@server/app/auth/routes.py`:
- Around line 108-111: The dummy verification currently swallows all exceptions
in the ph.verify(_DUMMY_HASH, data['password']) call; narrow this by importing
the specific Argon2 exceptions (e.g., VerifyMismatchError, VerificationError,
InvalidHash from argon2.exceptions) and replace the broad "except Exception"
with a targeted "except (VerifyMismatchError, VerificationError, InvalidHash):"
so only expected verification failures are ignored and other unexpected errors
still propagate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: be8a7a00-e3f0-4aea-b593-89408a2dcbc8
📒 Files selected for processing (5)
.gitignoredocs/transcript_sarah.mdrequirements.txtserver/app/__init__.pyserver/app/auth/routes.py
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/app/auth/routes.py`:
- Around line 27-32: The helper _invalid_fields currently assumes data is a dict
and will raise if given a non-object JSON; update _invalid_fields to first check
if data is a mapping (e.g., isinstance(data, dict)) and if not return the full
list of fields as "invalid" so callers can respond with a 400, and/or explicitly
validate request.get_json() in the /register and /login handlers before calling
_invalid_fields (if the body is not a dict return a 400 with a clear message).
Ensure you reference _invalid_fields when making the change so non-object JSON
payloads no longer cause a 500.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 749e2dc2-6ef6-476d-807f-d2f0b04947ff
📒 Files selected for processing (3)
docs/transcript_sarah.mdrequirements.txtserver/app/auth/routes.py
✅ Files skipped from review due to trivial changes (1)
- docs/transcript_sarah.md
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/app/auth/routes.py`:
- Around line 36-39: The register() and login() routes call request.get_json()
which raises BadRequest on malformed JSON before the dict check; update both
handlers to call request.get_json(silent=True) (or wrap the get_json call in a
try/except for BadRequest) so malformed JSON returns your normalized JSON 400
response; ensure you keep the existing isinstance(data, dict) guard and return
jsonify({'error': 'Request body must be a JSON object'}), 400 when data is None
or not a dict.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6e914227-ee26-43fa-919e-7d9a778b21dd
📒 Files selected for processing (2)
docs/transcript_sarah.mdserver/app/auth/routes.py
✅ Files skipped from review due to trivial changes (1)
- docs/transcript_sarah.md
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
server/app/auth/routes.py (1)
140-142:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRehash failure should not block successful login.
If the password was already verified but the rehash DB update fails, the exception is re-raised, returning a 500 to an otherwise-authenticated user. Since rehashing is a background optimization, consider logging the error and continuing to issue the token.
💡 Suggested fix
try: cursor.execute( """ UPDATE users SET argon2id_server_hash = %s, argon2id_server_salt = %s WHERE id = %s """, (new_hash, new_salt, user['id']), ) db.commit() except Exception: db.rollback() - raise + # Log but don't fail login — rehash is opportunistic + # TODO: Add proper logging here finally: cursor.close()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@server/app/auth/routes.py` around lines 140 - 142, The current except block around the password rehash update (the except Exception that calls db.rollback() and re-raises) will turn a rehash failure into a 500 for an otherwise-authenticated user; change this so the rehash failure is logged and swallowed while allowing token issuance to continue. Locate the rehash DB update in server/app/auth/routes.py (the try/except surrounding db.rollback()) and replace the re-raise with a logged error (use the existing logger/current_app.logger) and ensure any necessary rollback/cleanup still runs, but do not raise the exception so the route can proceed to issue the authentication token.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@server/app/auth/routes.py`:
- Around line 140-142: The current except block around the password rehash
update (the except Exception that calls db.rollback() and re-raises) will turn a
rehash failure into a 500 for an otherwise-authenticated user; change this so
the rehash failure is logged and swallowed while allowing token issuance to
continue. Locate the rehash DB update in server/app/auth/routes.py (the
try/except surrounding db.rollback()) and replace the re-raise with a logged
error (use the existing logger/current_app.logger) and ensure any necessary
rollback/cleanup still runs, but do not raise the exception so the route can
proceed to issue the authentication token.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ecebfeba-c0a6-4665-bf0e-e3f438b51922
📒 Files selected for processing (2)
docs/transcript_sarah.mdserver/app/auth/routes.py
✅ Files skipped from review due to trivial changes (1)
- docs/transcript_sarah.md
sreejita-saha
approved these changes
May 21, 2026
This was referenced May 21, 2026
Merged
Merged
Merged
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Security
Chores
Documentation
Style