Implement sass --embedded in pure JS mode
#2413
Conversation
ntkme
force-pushed
the
embedded-compiler
branch
from
8d7d4de to
7084da7
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
e66df5b to
d53fcc5
Compare
ntkme
force-pushed
the
embedded-compiler
branch
9 times, most recently
from
d7e6206 to
b3794eb
Compare
ntkme
force-pushed
the
embedded-compiler
branch
3 times, most recently
from
9112b44 to
54fabf3
Compare
ntkme
force-pushed
the
embedded-compiler
branch
8 times, most recently
from
257b4fd to
ac718ee
Compare
ntkme
force-pushed
the
embedded-compiler
branch
from
f6e6c4b to
1e8e188
Compare
ntkme
force-pushed
the
embedded-compiler
branch
3 times, most recently
from
7d10b08 to
6ef6075
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
77045ba to
37060c0
Compare
|
@nex3 I can see that the team is focusing most of the time on the postcss sass parser and this pull request has low priority. However, I would like to get this done in next few month before dart 3.8 become stable so that we can offer this as a replacement for dart ia32. Please take a look when you get a chance and let me know if you have any questions. |
|
Would really be great to see this merged to have embedded support on FreeBSD even if in pure JS mode. Thank you! |
ntkme
force-pushed
the
embedded-compiler
branch
from
37060c0 to
46ef47c
Compare
ntkme
force-pushed
the
embedded-compiler
branch
from
46ef47c to
a7a6b0e
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
5e40319 to
b819b68
Compare
| var packet = Uint8List( | ||
| 1 + _compilationIdVarint.length + protobufWriter.lengthInBytes, | ||
| ); | ||
| packet[0] = switch (message.whichMessage()) { | ||
| OutboundMessage_Message.compileResponse => 1, | ||
| OutboundMessage_Message.error => 2, | ||
| _ => 0, | ||
| OutboundMessage_Message.error => exitCode, |
There was a problem hiding this comment.
There's a risk here that exitCode is set to 0 or 1 and causes this to silently do the wrong thing. We should probably check for that, even if we're confident it can't occur with the code as-is.
There was a problem hiding this comment.
I decided to just use a second byte for this to avoid the conflict. Also added a comment explaining why that is needed.
| /// The entrypoint for a [ReusableIsolate]. | ||
| /// | ||
| /// This must return a Record of filename and argv for creating the Worker. | ||
| typedef ReusableIsolateEntryPoint = (String, JSArray<JSAny?>) Function(); |
There was a problem hiding this comment.
Two implementations of the same library should have exactly the same public interface—they shouldn't differ in which types they export.
There was a problem hiding this comment.
I understand this is ugly, but I cannot think of a better way to abstract this - the fundamental problem is that the way dart launches isolates and js launches workers are way too different. In dart VM you just launch the isolate with a reference to a function, but in JS you need to give it an entrypoint script filename, and arguments.
My end goal was that for ReusableIsolate class itself to share same interface, even if the type of entrypoint argument is different.
Let me know if you have a better idea.
lib/src/embedded/js/executable.dart
Outdated
| .listen(); | ||
| } else { | ||
| var port = workerData! as MessagePort; | ||
| isolateMain(JSSyncReceivePort(port), JSSendPort(port)); |
There was a problem hiding this comment.
The distinction between this isolateMain and the one that's passed to ReusableIsolate.spawn() is very confusing. Given that neither is consistently spawned as the main method of a new worker, it would be clearer to rename both to something that more explicitly describes what they do.
There was a problem hiding this comment.
I added a section and some diagrams in lib/src/embedded/README.md to explain how this convoluted process works.
Closes #2325.
sass/embedded-host-node#344
Implementation
The actual isolate dispatcher and compilation dispatcher are nearly unchanged. However, I had to replace isolate with worker communication, and mock tons of small things that do not work on node.
Testing