Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for bogus combinators #2536

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Drop support for bogus combinators #2536

merged 4 commits into from
Mar 8, 2025

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Mar 7, 2025

This also improves the way SassExceptions thrown from within custom
functions are handled. If the wrapped exception already has a span,
it's turned into a MultiSpanSassException with an additional span
pointing to the function invocation.

Closes #1727

[see sass/sass#4040]
[see sass/sass-spec#2049]

@nex3 nex3 requested a review from jathak March 7, 2025 01:04
@nex3 nex3 force-pushed the bogus-combinators branch 2 times, most recently from da94771 to abd62ef Compare March 7, 2025 01:33
This also improves the way SassExceptions thrown from within custom
functions are handled. If the wrapped exception already has a span,
it's turned into a MultiSpanSassException with an additional span
pointing to the function invocation.
@nex3 nex3 force-pushed the bogus-combinators branch from abd62ef to ee91154 Compare March 7, 2025 01:39
@nex3 nex3 requested a review from jathak March 7, 2025 22:20
@nex3 nex3 merged commit 499e140 into feature.v2 Mar 8, 2025
39 checks passed
@nex3 nex3 deleted the bogus-combinators branch March 8, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants