Add support for % as a stand-alone expression
#2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This also deprecates user-defined functions named "type". See #2539
Goodwine
approved these changes
Mar 12, 2025
Comment on lines
+169
to
+175
| /// Deprecation for functions named "type". | ||
| typeFunction( | ||
| 'type-function', | ||
| deprecatedIn: '1.86.0', | ||
| description: 'Functions named "type".', | ||
| ), | ||
|
|
There was a problem hiding this comment.
off-topic: for whatever reason when I generate the deprecations I end up getting a different formatting, like:
typeFunction('type-function', deprecatedIn: '1.86.0',
description: 'Functions named "type".'),do you happen to know what that would be? this is when running dart run grinder... I guess I may have some config file somewhere that tells dart to behave this way 🤔
There was a problem hiding this comment.
I saw something similar and I couldn't figure out exactly what it was. The Dart formatter is in the process of rolling out new changes so it's probably something related to that, but I don't know what exactly. I suspect making the generator add a trailing comma would force it to behave the same way for both the old and new formatter logic, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also deprecates user-defined functions named "type".
See #2539
[see sass/sass#4045]
[see sass/sass-spec#2051]