thread safe function helpers #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2019
|
Thanks! |
|
thanks @bolandrm ! It might be also related to #133 . should it be even possible to use different functions in a different context? I think that code should be deprecated (functions shouldn't be mutated during runtime) or we have to figure out a better api to do this. |
Closed
DavidKang
pushed a commit
to openSUSE/open-build-service
that referenced
this pull request
Mar 20, 2020
The concurency was causing random failure when precompiling the assets. This issue was fixed in [PR#138](sass/sassc-ruby#138).
DavidKang
pushed a commit
to DavidKang/open-build-service
that referenced
this pull request
Mar 22, 2020
Concurrency are raising failure during the precompile. There is an issue on sprocket related to this issue rails/sprockets#581 and sass/sassc-ruby#138.
DavidKang
pushed a commit
to DavidKang/open-build-service
that referenced
this pull request
Mar 22, 2020
Concurrency are raising failure during the precompile. There is an issue on sprocket related to this issue rails/sprockets#581 and sass/sassc-ruby#138.
DavidKang
pushed a commit
to openSUSE/open-build-service
that referenced
this pull request
Mar 22, 2020
Concurrency are raising failure during the precompile. There is an issue on sprocket related to this issue rails/sprockets#581 and sass/sassc-ruby#138.
DavidKang
pushed a commit
to DavidKang/open-build-service
that referenced
this pull request
Mar 22, 2020
Concurrency are raising failure during the precompile. There is an issue on sprocket related to this issue rails/sprockets#581 and sass/sassc-ruby#138.
DavidKang
pushed a commit
to openSUSE/open-build-service
that referenced
this pull request
Mar 22, 2020
Concurrency are raising failure during the precompile. There is an issue on sprocket related to this issue rails/sprockets#581 and sass/sassc-ruby#138.
DavidKang
pushed a commit
to DavidKang/open-build-service
that referenced
this pull request
Mar 22, 2020
Concurrency are raising failure during the precompile. There is an issue on sprocket related to this issue rails/sprockets#581 and sass/sassc-ruby#138.
DavidKang
pushed a commit
to DavidKang/open-build-service
that referenced
this pull request
Mar 22, 2020
Concurrency are raising failure during the precompile. There is an issue on sprocket related to this issue rails/sprockets#581 and sass/sassc-ruby#138.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rails/sprockets#581 sass/sassc-rails#121
I think there should be a better way to define custom functions, but unfortunatelly that would require changes in the API.
sprockets redefines functions which is super hacky
https://github.com/rails/sprockets/blob/1bcee8ebc03489eb7e42ee5c258a712443a6df3c/lib/sprockets/sassc_processor.rb#L58
https://github.com/rails/sprockets/blob/0cb3314368f9f9e84343ebedcc09c7137e920bc4/lib/sprockets/utils.rb#L126