feat: f2 interception and screenshot indicator #316
+18,224
−801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sassman
commented
Dec 27, 2025
sassman
commented
- feat: using crossterm key events to intercept the screenshot trigger
- feat: add countdown when t-rec starts, fix auto-skip countdown
- feat: create a lazy logger, so that no empty log file flies around
- chore: fix lints
- fix: fix outdated convert command call in docblock
- feat: use skylight as on-screen-display lib to show screenshot indicators
- feat: restructure to Cargo workspace with modular crates
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
…tors - also restructure threading and messaging so that we can broadcast events between threads (e.g. screenshots) Signed-off-by: Sven Kanoldt <[email protected]>
Enable cleaner architecture by splitting into workspace with skylight-osd crate for on-screen display functionality.
sassman
force-pushed
the
feat/crossterm-input-interception
branch
from
0e1b555 to
c9d0388
Compare
Signed-off-by: Sven Kanoldt <[email protected]>
- also add a README.md explaining a quickstart and the API and the examples - fix glitch with one particular but random white border showing up Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
sassman
force-pushed
the
feat/crossterm-input-interception
branch
from
0307c39 to
dc85c53
Compare
…new abstraction Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
…se backend internals in the prelude module Signed-off-by: Sven Kanoldt <[email protected]>
- Add layout module (Padding, Margin, Border, BoxModel) - Add style module (Paint, TextStyle) - Add background() and corner_radius() to OsdFlashBuilder - Add examples: battery, equalizer, radar, sierpinski - Fix canvas trait to use ref parameters - Fix content bounds and center positioning
- Add a keyframe based API to the OsdWindowBuilder - interpolates numerical values of color and scale between the phases of keyframes - has change detection based on object order in the keyframe "drawing" - based on the the architecture at `.planning/osd-flash-animation-architecture.md` the documentation is on a module level at `crates/osd-flash/src/animation/mod.rs` - Add a pulsing animation example (crates/osd-flash/examples/recording_indicator_pulse.rs) - todo: there is a small flickering, so we explore if double buffering from CALayer might help us
Add `osd-flash-indicator` feature flag (enabled by default) that: - Uses dual cfg guard (target_os + feature) for proper platform handling - Falls back to NoopPresenter when disabled or on non-macOS - Removes osd-flash from dependency tree when disabled This provides a rollback strategy if OSD issues arise: cargo build --release --no-default-features Also adds --no-default-features CI testing to verify rollback path.
… animations Signed-off-by: Sven Kanoldt <[email protected]>
sassman
force-pushed
the
feat/crossterm-input-interception
branch
from
ede5dd5 to
6f0d864
Compare
…ngs for the core-animation examples Signed-off-by: Sven Kanoldt <[email protected]>
- we are just about to overhaul osd-flash and simplify it greatly Signed-off-by: Sven Kanoldt <[email protected]>
Signed-off-by: Sven Kanoldt <[email protected]>
sassman
force-pushed
the
feat/crossterm-input-interception
branch
from
f4d7a9a to
98f3401
Compare
Signed-off-by: Sven Kanoldt <[email protected]>
sassman
force-pushed
the
feat/crossterm-input-interception
branch
from
98f3401 to
e089d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.