Add quiet (-q|--quiet) mode to suppress Ctrl+D banner #39
Conversation
Daviey
changed the title
| @@ -105,7 +105,11 @@ fn main() -> Result<()> { | |||
| println!("Recording window id: {}", win_id); | |||
| } | |||
| } | |||
| println!("Press Ctrl+D to end recording"); | |||
| if args.is_present("quiet") { | |||
| println!(); | |||
There was a problem hiding this comment.
Do we need to println!() at all? Do we need the extra \n?
There was a problem hiding this comment.
Yeah, I tried to express this in the commit message, "an empty string is outputted as the
application needs there to be something to begin recording".
Without it, there is no recording and the following output:
$ t-rec -q
[src/common/identify_transparency.rs:24] margin.top = 0
[src/common/identify_transparency.rs:34] margin.bottom = 0
[src/common/identify_transparency.rs:44] margin.left = 0
[src/common/identify_transparency.rs:54] margin.right = 0
$ echo $?
0
There was a problem hiding this comment.
Instead of println!(); you could use print!("{esc}[H", esc = 27 as char); that seems to work too.
The dbg output might be something that I forgot to remove.. in src/common/identify_transparency.rs.
There was a problem hiding this comment.
You're the boss, but that doesn't seem to work for me. Exhibits the same behaviour as no print at all. println!("{esc}[H", esc = 27 as char); works, would you prefer that to println!()?
There was a problem hiding this comment.
hm, interesting. What happens in your case? The recording does not start at all?
There was a problem hiding this comment.
I'm fine with the empty line for now, I don't mind. A future goal is to have a little count down indicating that the recording will start in 3, 2, 1 - <clear> So that a user gets feedback that it worked, and has 3 seconds to prepare and the recording will start on a clear screen.
There was a problem hiding this comment.
hm, interesting. What happens in your case? The recording does not start at all?
Nested t-rec didn't work very well... but yes. No attempt to record with that, just exit out (with the debug):
There was a problem hiding this comment.
println!(); doesn't actually output a new line on the recorded screen:
There was a problem hiding this comment.
Good to know, anyway the other issue that the recording does not start then is something I will dig into.
But as far as this PR is concerned the new line is fine for me.
Previously, all recordings would display, "Press Ctrl+D to end recording". This is helpful (& even desirable) on first usage. However, it is annoying to have the banner in all the recordings. This adds the ability to add -q|--quiet, which suppresses the banner making cleaner recordings. (An empty string is outputted as the application needs there to be something to begin recording) Signed-off-by: Dave Walker (Daviey) <[email protected]>
|
(@sassman I did look at those issues, but I didn't comment as I didn't have anything valuable to add. Thanks again!) |
Previously, all recordings would display, "Press Ctrl+D to end
recording". This is helpful (& even desirable) on first usage.
However, it is annoying to have the banner in all the recordings.
This adds the ability to add -q|--quiet, which suppresses the banner
making cleaner recordings. (An empty string is outputted as the
application needs there to be something to begin recording)
Signed-off-by: Dave Walker (Daviey) [email protected]