Skip to content

Add feature to take max-warnings option into account #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add feature to take max-warnings option into account #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d57b82
GH-73 Add feature to take max-warnings option into account
molsm Feb 24, 2019
c12ac2a
GH-73 Misstype corrections
molsm Feb 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ sassLint.format = function (writable) {

sassLint.failOnError = function () {
var filesWithErrors = [];
var filesWithWarnings = [];
var compile = through({objectMode: true}, function (file, encoding, cb) {
if (file.isNull()) {
return cb();
Expand All @@ -99,17 +100,37 @@ sassLint.failOnError = function () {
filesWithErrors.push(file);
}

if (file.sassLint[0].warningCount > 0) {
filesWithWarnings.push(file);
}

this.push(file);
cb();
}, function (cb) {
var errorMessage;
var errorMessage = [],
warningCount,
maxWarningLimit;

if (filesWithErrors.length > 0) {
errorMessage = filesWithErrors.map(function (file) {
return file.sassLint[0].errorCount + ' errors detected in ' + file.relative
}).join('\n');
});
}

if (filesWithWarnings.length > 0 && !isNaN(filesWithWarnings[0].sassConfig.options['max-warnings'])) {
maxWarningLimit = filesWithWarnings[0].sassConfig.options['max-warnings'];

warningCount = filesWithWarnings.reduce(function (accumulator, file) {
return accumulator + file.sassLint[0].warningCount;
}, 0);

if (warningCount > maxWarningLimit) {
errorMessage.push('Number of warnings (' + warningCount + ') exceeds the allowed maximum of ' + maxWarningLimit)
}
}

this.emit('error', new PluginError(PLUGIN_NAME, errorMessage));
if (errorMessage.length > 0) {
this.emit('error', new PluginError(PLUGIN_NAME, errorMessage.join('\n')));
}

cb();
Expand Down