Skip to content

WIP refactor #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

WIP refactor #14

wants to merge 5 commits into from

Conversation

yzqzss
Copy link
Member

@yzqzss yzqzss commented Apr 28, 2025

WIP refactor.

changes:

  • Remove --ignore-disposition-header-missing flag
  • Drop Python 3.8 support

@yzqzss yzqzss requested a review from Copilot May 7, 2025 16:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs a WIP refactor that drops Python 3.8 support and renames several functions and variables to adopt a consistent snake_case naming convention while updating dependency versions.

  • Updated pyproject.toml to require Python ^3.9 and bump dependency versions
  • Renamed and refactored functions (e.g. getTitles to get_titles, standardizeUrl to standardize_url) and variables for consistency
  • Removed the --ignore-disposition-header-missing flag from the argument parser and related code

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Updated Python version and dependencies
dokuWikiDumper/utils/util.py Added type overloads and improved variable naming in smkdirs
dokuWikiDumper/utils/session.py Replaced bare excepts with “except Exception” for clarity
dokuWikiDumper/dump/* Renamed functions and variables to follow snake_case convention
README.md Updated documentation to reflect new bot behavior and API usage
.github/workflows/python-package.yml Removed Python 3.8 support from CI matrix
Comments suppressed due to low confidence (2)

dokuWikiDumper/dump/content/init.py:125

  • The variable name 'srouce' appears to be a typo. It should be renamed to 'source' for clarity and consistency.
srouce = task.getSource(task.doku_url, task.title, session=task.session)

dokuWikiDumper/dump/content/init.py:31

  • The constant 'POSION' seems to be a typo. Consider renaming it to 'POISON' to more clearly indicate its purpose as a poison pill in the task queue.
POSION = None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant