Add deterministic DQN tests, CI checks, and local typecheck/test commands - #5
Merged
sbischoff-ai merged 1 commit intoMar 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tests), and unit tests to catch regressions earlier.Description
tests/dummy_test.pywith deterministic tests that coverReplayBuffer,EpsilonScheduler/ epsilon-greedy behavior, DQN target/loss calculation and learning-step invariants (global_step, epsilon update), and a short smoke integration run onCounterEnv(seeds are set via a helper_set_all_seeds)..github/workflows/ci.ymlto run explicit quality commands:uv run black --check adeptly tests,uv run mypy adeptly tests, anduv run pytest -q.Makefiletypechecktarget tomypy adeptly testsso localmake typecheckchecks tests as well as package code.README.mddevelopment/checks section to document the same direct commands for local validation (uv run black --check adeptly tests,uv run mypy adeptly tests,uv run pytest -q).Testing
uv run black --check adeptly testsand it completed successfully (no formatting changes reported).uv run mypy adeptly testsand it reportedSuccess: no issues found.uv run pytest -qand all tests passed (15 passed), verifying the new deterministic tests and existing suite.Codex Task