Repository navigation
fix(updater): make migration 801 idempotent for existing lockout columns - #1473
Merged
Merged
Conversation
Panels upgrading from v1.8.x or re-running the updater after a partial pass already carry `attempts` and `lockout_until` on `:prefix_admins`; the bare ADD COLUMN shape fatals with SQLSTATE[42S21]. Use ADD IF NOT EXISTS to match sibling migrations and add regression tests for full and partial re-runs. Fixes #1472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/updater/data/801.phpto useADD IF NOT EXISTSfor theattemptsandlockout_untilcolumns on:prefix_admins, matching the idempotent pattern used by sibling migrations (112.php,150.php, etc.).struc.sqlor a prior failed run; the bareADD COLUMNshape fatals withSQLSTATE[42S21] Duplicate column name 'attempts'.Updater801LockoutColumnsTestcovering full idempotent re-run and partial-failure recovery (onlylockout_untilmissing).Test plan
./sbpp.sh test --filter=Updater801LockoutColumnsTest(2 tests, 8 assertions)/updater/against a DB whose:prefix_adminsalready hasattempts/lockout_untilbutconfig.versionis still< 801