Skip to content

Composer(deps-dev): Bump staabm/phpstan-dba to 0.4.9 (+ PHPStan ignore fix) #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rushaway merged 2 commits into from
Aug 5, 2026
Merged

Composer(deps-dev): Bump staabm/phpstan-dba to 0.4.9 (+ PHPStan ignore fix) #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca822db
Composer(deps-dev): Bump staabm/phpstan-dba from 0.4.2 to 0.4.9 in /web
dependabot[bot] Aug 3, 2026
ff43a1d
fix(phpstan): drop unused ignores after phpstan-dba 0.4.9 bump
maxijabase Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions web/composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 2 additions & 7 deletions web/install/pages/page.3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,15 @@
// PHP requirements
$phpRows = [];

// PHPStan sees the analyser's PHP_VERSION as a fixed string (the
// container is locked to 8.5+) so the `version_compare(...)` here
// looks always-true to it. The check still has runtime value: a
// self-hoster on PHP 8.4 hitting this surface is exactly who needs
// the "you're on too old a version" feedback.
// Runtime gate for self-hosters below the PHP 8.5 floor. The analyser
// environment is locked to 8.5+, so this branch is not exercised there.
$phpVersionOk = version_compare(PHP_VERSION, '8.5', '>=');
$phpRows[] = [
'label' => 'PHP version',
'required' => '8.5 or newer',
// @phpstan-ignore ternary.alwaysTrue
'status' => $phpVersionOk ? 'ok' : 'err',
'detail' => PHP_VERSION,
];
// @phpstan-ignore booleanNot.alwaysFalse
if (!$phpVersionOk) {
$errors++;
}
Expand Down
Loading