Repository navigation
fix(admin-mods): modernize mods list and forms (#1552) - #1552
Merged
Merged
Conversation
Rushaway
changed the title
Rushaway
changed the title
Rushaway
approved these changes
Aug 9, 2026
Rushaway
enabled auto-merge
August 9, 2026 16:32
4 of 7 tasks
rumblefrog
force-pushed
the
feat/mods-list-compact-actions
branch
from
September 6, 2026 19:48
3df1d55 to
a7e758c
Compare
rumblefrog
reviewed
Sep 6, 2026
|
|
||
| global $userbank, $theme; | ||
|
|
||
| new \Sbpp\View\AdminTabs([], $userbank, $theme); |
Member
There was a problem hiding this comment.
Conflicts with current convention, adding this back.
rumblefrog
reviewed
Sep 6, 2026
| // mid=0 is the reserved Web pseudo-mod, not a configurable game mod. | ||
| $mod_list = $GLOBALS['PDO']->query("SELECT * FROM `:prefix_mods` WHERE mid > 0 ORDER BY name ASC")->resultset(); | ||
| $mod_count = (int) $GLOBALS['PDO']->query("SELECT COUNT(mid) AS cnt FROM `:prefix_mods`")->single()['cnt']; | ||
| $mod_count = (int) $GLOBALS['PDO']->query("SELECT COUNT(mid) AS cnt FROM `:prefix_mods` WHERE mid > 0")->single()['cnt']; |
Member
There was a problem hiding this comment.
We need to exclude the pseudo mod
rumblefrog
reviewed
Sep 6, 2026
| */ | ||
| public function __construct( | ||
| public readonly bool $permission_listmods, | ||
| public readonly bool $permission_addmods, |
rumblefrog
force-pushed
the
feat/mods-list-compact-actions
branch
from
September 6, 2026 20:27
0cf6b04 to
bd8e3ac
Compare
rumblefrog
disabled auto-merge
September 6, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the admin Mods surfaces in line with the rest of the v2 panel list / form chrome.
List mods (
?p=admin&c=mods§ion=list)table--compactdesktop table (less vertical padding per row).pencil/trash-2) withdata-tooltip+aria-label, matching banlist / admins..mods-list-cards) so the table is not hidden and does not force horizontal scroll under 768px. Delete removes both the desktop row and the mobile card.Add mod (
section=add)card__header).Edit mod (
o=edit)AdminTabsBack strip that left dead space above the form (redundant with the footer Back next to Save).Motivation and Context
Mods list / add / edit still used the older “title inside the card + text Edit/Delete + keep-mobile table” shape after bans, comms, and admins moved to compact tables, icon actions, page titles, and mobile cards. This PR closes that visual and responsive gap without changing mod semantics or APIs.
How Has This Been Tested?
:8080mod-row,deletemod-btn, mod-delete dialog) kept; count badge format now(N)like adminsScreenshots (if appropriate):
Before
RB3SxxykDV.mp4
After
chrome_XpOmzWRTum.mp4
Types of changes
Checklist: