Skip to content

fix(plugin): avoid BanClient before the player entity exists (#1579) #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rumblefrog merged 1 commit into from
Sep 28, 2026
Merged

fix(plugin): avoid BanClient before the player entity exists (#1579) #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions game/addons/sourcemod/scripting/sbpp_main.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,12 +1746,24 @@ public void VerifyBan(Database db, DBResultSet results, const char[] error, int

db.Query(ErrorCheckCallback, Query, client, DBPrio_High);

char kickMessage[256];
char kickMessage[256], gameAuth[MAX_AUTHID_LENGTH];
FormatEx(kickMessage, sizeof(kickMessage), "%T", "Banned Check Site", client, WebsiteAddress);

// BANFLAG_AUTO makes SourceMod use the game's native auth string.
// Synergy rejects Steam2 IDs here, but accepts its native Steam3 ID.
BanClient(client, 5, BANFLAG_AUTO, kickMessage, kickMessage, "", 0);
// Don't use BanClient() here: it needs the player entity, which may not exist
// yet (OnClientAuthorized can precede OnClientPutInServer). Ban the engine auth
// string (Synergy rejects Steam2), falling back to IP on LAN or lookup failure.
if (GetClientAuthId(client, AuthId_Engine, gameAuth, sizeof(gameAuth))
&& BanIdentity(gameAuth, 5, BANFLAG_AUTHID, kickMessage, "", 0))
{
KickClient(client, "%s", kickMessage);
}
else
{
// Kick before addip, as BanClient does, so the client sees our message.
KickClientEx(client, "%s", kickMessage);
if (clientIp[0] != '\0')
BanIdentity(clientIp, 5, BANFLAG_IP, kickMessage, "", 0);
}

return;
}
Expand Down
Loading