Cross build to sbt 2.0.0-RC4 #48
Open
+136
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
eed3si9n
force-pushed
the
wip/cross-build
branch
from
54cf1aa to
036c53a
Compare
eed3si9n
force-pushed
the
wip/cross-build
branch
from
036c53a to
5f8ec25
Compare
gaeljw
reviewed
Sep 8, 2025
| // dependencies | ||
| val packagerVersion = "1.11.3" | ||
| val packager19xVersion = "1.9.16" | ||
|
|
||
| val scala212 = "2.12.20" | ||
| val scala3 = "3.7.2" |
There was a problem hiding this comment.
Naive question out of curiosity: we can use Scala 3.7 in the plugin because SBT 2.x itself is in Scala 3.7, right? I ask because I was expecting to see a Scala 3 LTS version (3.3.x) to ensure the plugin can be consumed in various version of SBT 2.x but I guess SBT 2.x (not RC) won't be released until the next LTS anyway?
There was a problem hiding this comment.
sbt 2.x doesn't follow LTS since it on its own isn't a library, and sbt using the latest allows greater flexibility in the plugin ecosystem.
|
Some of the failing tests are more to do with sbt 2 rather than the plugin itself, so I've moved them into a different directory so sbt 1.x would test it but not sbt 2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43