Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research review app reinitialization #158

Open
jacobwegner opened this issue Jun 26, 2023 · 3 comments
Open

Research review app reinitialization #158

jacobwegner opened this issue Jun 26, 2023 · 3 comments
Assignees
@jacobwegner

Comments

@jacobwegner
Copy link
Contributor

Discovered by @jchill-git on #156; the review app is getting deleted when a git push is made:

image

Possibly related to:

https://help.heroku.com/YCFHG3X6/why-is-my-review-app-being-recreated-on-every-push-to-the-github-pull-request

image

@jacobwegner to investigate
@jacobwegner jacobwegner self-assigned this Jun 26, 2023
@jacobwegner
Copy link
Contributor Author

Testing out a fix in f0d5dd0 (via https://stackoverflow.com/a/57904079)

jacobwegner added a commit that referenced this issue Jun 27, 2023
@jacobwegner
Backport review apps fixes from feature/cambridge-greek-lexicon
6c5117d 
Refs #158
@jacobwegner jacobwegner mentioned this issue Jun 27, 2023
Merged
3 tasks
@jacobwegner
Copy link
Contributor Author

Testing a fix in #159.

@jacobwegner
Copy link
Contributor Author

The fix in #159 seems to prevent the review app from being deleted, but we're still seeing an intermittent failure. I've reached out to Heroku Support, but we may want to investigate a few other approaches as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwegner jacobwegner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobwegner