Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport review apps fixes from feature/cambridge-greek-lexicon #159

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

jacobwegner
Copy link
Contributor

@jacobwegner jacobwegner commented Jun 27, 2023

Refs #158

Verifying these changes:

  • Browse to beyond-translation-pipeline in Heroku and create a new review app from this PR
  • Commit changes to the PR
  • Verify that changes refresh, not rebuild the review app

@scaife-viewer-service-account scaife-viewer-service-account temporarily deployed to beyond-transl-pr-159 June 27, 2023 12:42 Inactive
@jacobwegner
Copy link
Contributor Author

Ok, progress.

The last build failed, but it did not "nuke" the review app:

 ---> Running in 3990649435c8
yarn run v1.22.5
$ vue-cli-service build
-  Building for production...
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
...
error Command failed with signal "SIGKILL".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command '/bin/sh -c yarn build' returned a non-zero code: 1

I'm thinking that we need to either optimize / increase the memory usage during the build (may not be able to configure Heroku to do so) or use an alternate form of deployment for review apps.

@jacobwegner
Copy link
Contributor Author

Heroku support indicated that there is indeed a "hard" limit during builds; I'm going to merge these changes in as I think it helps some of the stability, and we can revisit GitHub Actions for handling review app builds automatically in the future.

(GitHub Actions is how we're doing production / staging deploys already)

@jacobwegner jacobwegner merged commit efb3b0f into main Jul 5, 2023
@jacobwegner jacobwegner deleted the fix/review-apps-init branch July 5, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants