Combine RepoConfig with the one taken the higher importance on the right side
#3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…right side. This is done in the `RepoConfigLoader` with the default config and the supplied additional configs. And now here in the same way. The `RepoConfig.combine` function treats the 2nd argument as the one overwriting the 1st one in cas emerging doesn't make sense. This applies at the moment only for "pin".
alejandrohdezma
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in the
RepoConfigLoaderwith the default config and the supplied additional configs. And now here in the same way.The
RepoConfig.combinefunction treats the 2nd argument as the one overwriting the 1st one in cas emerging doesn't make sense. This applies at the moment only for "pin".This fixes the problem reported in typelevel/sbt-typelevel#703 (comment)
Without the fix the https://github.com/typelevel/sbt-typelevel/blob/main/.scala-steward.conf was overwriting the config supplied by the repo https://github.com/typelevel/sbt-typelevel/blob/main/.scala-steward.conf
This became a problem after #3305 and resulted in a not wanted pull request: typelevel/sbt-typelevel#703