Backport "Fix Java record problems (#19578) and (#19386)" to LTS - #20890
Merged
Conversation
WojciechMazur
force-pushed
the
lts-19645
branch
2 times, most recently
from
June 30, 2024 21:58
0537c37 to
70f0486
Compare
[Cherry-picked 64a8865]
This fixes a whole host of subtle issues. - The type parameter was not stamped correctly on the constructor causing the original error - The parsed record was not stamped with `JavaDefined`, which meant the duplicate constructors in the case of overrides were not removed. [Cherry-picked f7eb589]
[Cherry-picked 781c25f]
We change the proxy method to take in a single argument. This also exposed a second issue where the overriden methods were not invalidated correctly in the `Namer`. [Cherry-picked 47511ae]
[Cherry-picked c532dd7]
[Cherry-picked 5be6fac]
Contributor
Author
|
No regressions detected in the community build up to lts-19605. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #19583 to the LTS branch.
PR submitted by the release tooling.
[skip ci]