-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix line and path separators in test #23534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
A NL is dropped from check files of bootstrapped neg-macros but it's not obvious how to supply the update flag. Edit: just |
db2c829
to
31b4fd4
Compare
Spurious windows_fast failure. |
31b4fd4
to
c6fa07f
Compare
c6fa07f
to
2d3adb2
Compare
That's a nice idea! Did you actually try it again under windows to see if it akshually works? Edit: the TestReporter's ConsoleReporter (its Probably the TestReporter is not used to report a path in a diagnostic, but it also translates paths, because why not. The test rig reports "local" paths as usual, but the diagnostics don't include a path (which would be normalized). Note, of course, how sbt "progress" collides with test rig output, which is still quite annoying and provides no value. Windows example where a spurious
In fact Edit: that is, local convention is good for test rig reports; normalized path is required only for check file output. |
2d3adb2
to
45afde7
Compare
Fixes #23458
Splitting on NL leaves the CR if present. Just use
linesIterator
.Introduce a template method for rendering paths. The test reporter replaces windows convention when run on windows, so that check files are correct;
FileDiff.matches
currently accounts for comparing lines of text when run on windows.Previously, a
TestReporter
with empty console output would contribute a NL because"".split("\n")
is not empty. (There is a test reporter per compilation group.)