fix: make vals created in desugaring of n-ary lambdas non-synthetic #23896
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Sep 12, 2025
| @@ -1964,7 +1964,6 @@ object desugar { | |||
| ValDef(param.name, param.tpt, selector(idx)) | |||
| .withSpan(param.span) | |||
| .withAttachment(UntupledParam, ()) | |||
| .withFlags(Synthetic) | |||
There was a problem hiding this comment.
@jchyb could this cause any issue for coverage? I think we were discussing that with @kasiaMarek
There was a problem hiding this comment.
I don't think it will make any difference. We recently removed filtering out Synthetic calls for methods (they caused issues for case classes, where most used methods are synthetic), but I don't think anything like that has existed for vals (I suspect we will just get more coverage tags than necessary, but we don't necessarily need the Synthetic flag to be there to be able to fix that).
tgodzik
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #16110
resolves: scalameta/metals#7594