Skip to content

Fix:Resolve ambiguous overload between empty param list and v… #24873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krrish175-byte wants to merge 5 commits into
base: main
Choose a base branch
from
+12 −2
Open

Fix:Resolve ambiguous overload between empty param list and v… #24873

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd76912
Fix #24871: Resolve ambiguous overload between empty param list and v…
krrish175-byte Dec 31, 2025
a585482
Simplify isVarArgsMethod check as suggested in review
krrish175-byte Jan 2, 2026
878da47
Fix test file: wrap for-yield expression in object method
krrish175-byte Jan 3, 2026
48a81e5
Fix bootstrap test failures in overload resolution between empty para…
krrish175-byte Jan 4, 2026
d041779
Remove debug prints and delete ambiguous test i24871
krrish175-byte Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions compiler/src/dotty/tools/dotc/typer/Applications.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,15 +2036,25 @@ trait Applications extends Compatibility {
*/
def isAsGood(alt1: TermRef, tp1: Type, alt2: TermRef, tp2: Type): Boolean = trace(i"isAsGood $tp1 $tp2", overload) {
tp1 match

case tp1: MethodType => // (1)
tp1.paramInfos.isEmpty && tp2.isInstanceOf[LambdaType]
|| {
val cond1 = tp1.paramInfos.isEmpty
&& tp2.isInstanceOf[LambdaType]
&& {
// When tp1 is nullary (empty parameter list), it's as good as tp2 only if
// tp2 is not a varargs method (which is less specific than an explicit empty list)
tp2 match
case tp2: MethodType => !tp2.isVarArgsMethod
case _ => true
}
val cond2 = {
if tp1.isVarArgsMethod then
tp2.isVarArgsMethod
&& isApplicableMethodRef(alt2, tp1.paramInfos.map(_.repeatedToSingle), WildcardType, ArgMatch.Compatible)
else
isApplicableMethodRef(alt2, tp1.paramInfos, WildcardType, ArgMatch.Compatible)
}
cond1 || cond2
Copy link
Contributor

@som-snytt som-snytt Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely would not want to eagerly evaluate the second expression.

case tp1: PolyType => // (2)
inContext(ctx.fresh.setExploreTyperState()) {
// Fully define the PolyType parameters so that the infos of the
Expand Down
Loading