Actually run tests in FromTastyTests? #24904
Draft
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not sure adding |
Contributor
|
I noticed yesterday that "coverage" tests aren't running because of a tasty flag (due to scala 2 lib history). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this while trying to add a Mill build in the Scala 3 repo. It seems the second half of each test from
FromTastyTestsdoesn't do anything by default, IIUC the current code (targetsremaining empty around the changed code inParallelTesting.scala). So the second commit in this PR fixes that. It seems many test cases break when doing it. As a first workaround, the second commit also adds-experimentalto allFromTastyTeststest cases, that seems required for many of them.