Optimizer tests (disabled for now) #24948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolalPirelli
commented
Jan 13, 2026
| @@ -1,17 +1,15 @@ | |||
| package dotty.tools.backend.jvm | |||
Contributor
Author
There was a problem hiding this comment.
re: the icon.png deletion above, every time I open the project IntelliJ wants to do this, so...
SolalPirelli
commented
Jan 13, 2026
SolalPirelli
commented
Jan 13, 2026
SolalPirelli
commented
Jan 13, 2026
|
|
||
| val fun = getMethod(clsNode, "test") | ||
| val instructions = instructionsFromMethod(fun) | ||
| val expected = // TODO room for constant folding |
Contributor
Author
There was a problem hiding this comment.
I checked, this TODO was done (the code below was modified but this todo was kept)
SolalPirelli
commented
Jan 13, 2026
compiler/test/dotty/tools/backend/jvm/OptimizationBytecodeTests.scala
Outdated
Show resolved
Hide resolved
SolalPirelli
commented
Jan 13, 2026
SolalPirelli
commented
Jan 13, 2026
|
|
||
| object Warmup { | ||
| def filter[A](p: Any => Boolean): Any = filter[Any](p) | ||
| def filter[A](p: Any => Boolean): Int = 1 + filter[Any](p) |
Contributor
Author
There was a problem hiding this comment.
this one was modified in the scala2 repo at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried porting the interesting stuff from scala2 as end-to-end tests that assert equivalence or high-level properties, rather than depending on specific bytecode shapes.
Part of #22667
Contributes to #3126