Fix secondary constructor capture checking#25841
Open
odersky wants to merge 2 commits intoscala:mainfrom
Open
Conversation
Secondary constructors lost parameter captures. This is fixed now. As a result, scala.util.Random is now safe to use from safe mode.
The previous treatment was wrong if fields have LocalCaps with different classifiers that have a common ancestor classifier class. In that case we created an unclassified LocalCap instead of a LocalCap with the common ancestor classifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secondary constructors lost parameter captures. This is fixed now. As a result, scala.util.Random is now safe to use from safe mode.
Solution sketch: We keep track of which parameters in secondary constructors flow into a parameter of the primary constructor. For arguments of secondary constructors corresponding to such parameters we can use their actual capture sets. For primary constructor parameters that are not instantiated with an argument of a secondary constructors we assume that they keep their declared formal parameter capture set, which is a conservative appoximation.