Skip to content

Handle Typed(_: SubMatch) in PatternMatcher #25904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EugeneFlesselle wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Handle Typed(_: SubMatch) in PatternMatcher #25904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9b2a7e
handle SubMatch in ensureNoLocalRefs
zielinsky Apr 13, 2026
c2096b3
add i25746 to excludelist for coverage test
zielinsky Apr 14, 2026
4c51089
Handle `Typed(_: SubMatch)` in `PatternMatcher`
EugeneFlesselle Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,12 +531,13 @@ object PatternMatcher {

private def caseDefPlan(scrutinee: Symbol, cdef: CaseDef): Plan =
val CaseDef(pat, guard, body) = cdef
val caseDefBodyPlan: Plan = body match
def caseDefBodyPlan(body: Tree = body): Plan = body match
case Typed(t, _) => caseDefBodyPlan(t)
case t: SubMatch => subMatchPlan(t)
case _ => ResultPlan(body)
val onSuccess: Plan =
if guard.isEmpty then caseDefBodyPlan
else TestPlan(GuardTest, guard, guard.span, caseDefBodyPlan)
if guard.isEmpty then caseDefBodyPlan()
else TestPlan(GuardTest, guard, guard.span, caseDefBodyPlan())
patternPlan(scrutinee, pat, onSuccess)
end caseDefPlan

Expand Down
1 change: 1 addition & 0 deletions compiler/test/dotc/scoverage-ignore.excludelist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,4 @@ tailrec.scala
traitParams.scala
i25460.scala
matrix.scala
i25746.scala
9 changes: 9 additions & 0 deletions tests/pos/i25746.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import scala.language.experimental.subCases

@main def test =
val r1 = "^foo".r.unanchored
val r2 = "bar$".r.unanchored

val result1 = "foo bar" match
case s @ r1() if s match { case r2() => s }
case _ => "no"
Loading